-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(attributes): Add LCP and CLS web vital report event attribute #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "browser.web_vital.cls.report_event", | ||
| "brief": "The event that caused the SDK to report CLS (pagehide or navigation)", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "navigation", | ||
| "sdks": ["javascript-browser"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [319], | ||
| "description": "Added browser.web_vital.cls.report_event attribute" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "key": "browser.web_vital.lcp.report_event", | ||
| "brief": "The event that caused the SDK to report LCP (pagehide or navigation)", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "pagehide", | ||
| "sdks": ["javascript-browser"], | ||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [319], | ||
| "description": "Added browser.web_vital.lcp.report_event attribute" | ||
| } | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "key": "sentry.report_event", | ||
| "brief": "(Deprecated) The event that caused the SDK to report CLS or LCP (pagehide or navigation)", | ||
| "type": "string", | ||
| "pii": { | ||
| "key": "maybe" | ||
| }, | ||
| "is_in_otel": false, | ||
| "example": "pagehide", | ||
| "sdks": ["javascript-browser"], | ||
| "deprecation": { | ||
| "reason": "The report event is now recorded as a browser.web_vital.lcp.report_event or browser.web_vital.cls.report_event attribute. No backfill required.", | ||
| "_status": null | ||
| }, | ||
|
Comment on lines
+11
to
+14
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I documented the old attribute (currently still sent with v1 standalone web vital spans) and marked it as deprecated. Since there's no 1:1 replacement but SDKs send one of two different attributes depending on the span, I left |
||
| "changelog": [ | ||
| { | ||
| "version": "next", | ||
| "prs": [320], | ||
| "description": "Added sentry.report_event attribute" | ||
| } | ||
| ] | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.