Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Other
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Deps Dev
Other
Other
🤖 This preview updates automatically when you update the PR. |
Add app_start_cold and app_start_warm as deprecated attributes pointing to app.vitals.start.cold.value and app.vitals.start.warm.value. Also adds alias cross-references on the new attributes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
buenaflor
force-pushed
the
giancarlobuenaflor/add-app-start-ttid-ttfd-attributes
branch
from
35aaa1f to
e0b9378
Compare
buenaflor
requested review from
a team,
Lms24,
cleptric,
lcian,
mjq and
nsdeschenes
as code owners
There was a problem hiding this comment.
Pull request overview
This PR completes the mobile vitals legacy-deprecation set by adding deprecated legacy attributes for cold/warm app start durations and wiring up symmetric aliases to the newer app.vitals.* attributes.
Changes:
- Add new deprecated attributes
app_start_coldandapp_start_warm(backfill) with replacements pointing toapp.vitals.start.cold.value/app.vitals.start.warm.value. - Add alias cross-references on
app.vitals.start.cold.valueandapp.vitals.start.warm.valueto the legacy keys. - Regenerate language bindings / generated outputs to include the new attributes (Python/JS + shared deprecated list).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/deprecated_attributes.json | Adds generated deprecated entries for app_start_cold and app_start_warm. |
| python/src/sentry_conventions/attributes.py | Adds constants + metadata + alias links for new deprecated attributes in Python bindings. |
| model/attributes/app_start_warm.json | Defines legacy app_start_warm attribute as deprecated with replacement + alias. |
| model/attributes/app_start_cold.json | Defines legacy app_start_cold attribute as deprecated with replacement + alias. |
| model/attributes/app/app__vitals__start__warm__value.json | Adds alias back to app_start_warm for symmetric aliasing. |
| model/attributes/app/app__vitals__start__cold__value.json | Adds alias back to app_start_cold for symmetric aliasing. |
| javascript/sentry-conventions/src/attributes.ts | Adds constants/types/metadata and alias links for the new deprecated attributes in JS bindings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lms24
approved these changes
Apr 15, 2026
Contributor
Author
|
@Lms24 you mind if I merge this? since we have the 3 day review period now but I think its fine in this case since it should've been part of the previous PR |
buenaflor
deleted the
giancarlobuenaflor/add-app-start-ttid-ttfd-attributes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
app_start_coldandapp_start_warmas deprecated attributes pointing toapp.vitals.start.cold.valueandapp.vitals.start.warm.valueapp.vitals.start.cold.valueandapp.vitals.start.warm.valueattributesThis was missed in #313 which added the other deprecated legacy attributes (
app_start_type,time_to_full_display,time_to_initial_display,frames.*).Test plan
yarn testpasses (4921 tests)yarn lintpassesyarn run generateproduces consistent output🤖 Generated with Claude Code