Skip to content

fix: Correct replacement for "ai.finish_reason" #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loewenheim wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Correct replacement for "ai.finish_reason" #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af022cf
fix: Correct replacement for `"ai.finish_reason"`
loewenheim Apr 16, 2026
c37f961
generate
loewenheim Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions javascript/sentry-conventions/src/attributes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export type AI_DOCUMENTS_TYPE = Array<string>;
*
* Aliases: {@link GEN_AI_RESPONSE_FINISH_REASONS} `gen_ai.response.finish_reasons`
*
* @deprecated Use {@link GEN_AI_RESPONSE_FINISH_REASON} (gen_ai.response.finish_reason) instead
* @deprecated Use {@link GEN_AI_RESPONSE_FINISH_REASONS} (gen_ai.response.finish_reasons) instead
* @example "COMPLETE"
*/
export const AI_FINISH_REASON = 'ai.finish_reason';
Expand Down Expand Up @@ -12556,7 +12556,7 @@ export const ATTRIBUTE_METADATA: Record<AttributeName, AttributeMetadata> = {
isInOtel: false,
example: 'COMPLETE',
deprecation: {
replacement: 'gen_ai.response.finish_reason',
replacement: 'gen_ai.response.finish_reasons',
},
aliases: [GEN_AI_RESPONSE_FINISH_REASONS],
changelog: [{ version: '0.1.0', prs: [55, 57, 61, 108, 127] }],
Expand Down
2 changes: 1 addition & 1 deletion model/attributes/ai/ai__finish_reason.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"example": "COMPLETE",
"deprecation": {
"_status": null,
"replacement": "gen_ai.response.finish_reason"
"replacement": "gen_ai.response.finish_reasons"
},
"alias": ["gen_ai.response.finish_reasons"],
"changelog": [
Expand Down
4 changes: 2 additions & 2 deletions python/src/sentry_conventions/attributes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
Contains PII: maybe
Defined in OTEL: No
Aliases: gen_ai.response.finish_reasons
DEPRECATED: Use gen_ai.response.finish_reason instead
DEPRECATED: Use gen_ai.response.finish_reasons instead
Example: "COMPLETE"
"""

Expand Down Expand Up @@ -6337,7 +6337,7 @@ class ATTRIBUTE_NAMES(metaclass=_AttributeNamesMeta):
pii=PiiInfo(isPii=IsPii.MAYBE),
is_in_otel=False,
example="COMPLETE",
deprecation=DeprecationInfo(replacement="gen_ai.response.finish_reason"),
deprecation=DeprecationInfo(replacement="gen_ai.response.finish_reasons"),
aliases=["gen_ai.response.finish_reasons"],
changelog=[
ChangelogEntry(version="0.1.0", prs=[55, 57, 61, 108, 127]),
Expand Down
2 changes: 1 addition & 1 deletion shared/deprecated_attributes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,7 @@
"example": "COMPLETE",
"deprecation": {
"_status": null,
"replacement": "gen_ai.response.finish_reason"
"replacement": "gen_ai.response.finish_reasons"
},
"alias": ["gen_ai.response.finish_reasons"],
"changelog": [
Expand Down
Loading