-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(metrics): remove old metrics platform-includes #16058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove orphaned platform-includes files that are no longer referenced in the metrics documentation. These files appear to be remnants from a previous metrics documentation refactoring. Files removed: - configure/* (9 files) - No longer referenced by any metrics pages - counter-snippet/javascript.mdx - Unused snippet file - distribution-snippet/javascript.mdx - Unused snippet file - gauge-snippet/javascript.mdx - Unused snippet file - set-snippet/javascript.mdx - Unused snippet file - setup/javascript.mdx - Unused setup file - metrics-units/python.mdx - No references found in codebase - version-support-note/* (3 files) - No longer included in metrics pages Verified by searching for PlatformContent includePath references and direct grep searches across the documentation. The remaining files in platform-includes/metrics/ (usage, options, requirements, default-attributes) are still actively used by Python, PHP, JavaScript, Ruby, and React Native metrics documentation. Co-Authored-By: Claude <noreply@anthropic.com>
…tsentry/sentry-docs into docs/remove-old-metrics-files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning things up @Flash0ver 🙇
The React Native removals LGTM. The rest of the changes also make sense 👍
chargome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
DESCRIBE YOUR PR
During getsentry/sentry-dotnet#4834 and #16054, I noticed that the Metrics dev docs still had some leftovers from the old Metrics implementation. These confused me a bit - I joined after they've been removed already.
I hope that removing them makes it easier to generate/write the metrics docs for upcoming SDKs.
Additionally, I hope that we weren't overzealous removing these platform-includes.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: