-
-
Notifications
You must be signed in to change notification settings - Fork 229
feat: Network calls for Session Replay on Android #4860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
=======================================
Coverage 73.87% 73.87%
=======================================
Files 483 483
Lines 17578 17578
Branches 3464 3464
=======================================
Hits 12985 12985
Misses 3740 3740
Partials 853 853 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… .NET and Java replay breadcrumbs
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
Test
Other
🤖 This preview updates automatically when you update the PR. |
|
Resolves #4192:
This PR ensures performanceSpans are sent with replay events so that outbound network requests in Maui for Android are displayed correctly in the
Replay -> Networktab.Implementation notes
The performanceSpan itself doesn't include a replyId, so it has to be sent along with the replay event - i.e. it gets sent by the mobile/Android SDK. The way android does this is to inspect the stream of breadcrumbs and convert these into RRWeb custom events. Typicallly this is done via the DefaultBreadcrumbConverter but it's also possible to swap that out with a custom converter (which is what our ReactNative SDK does).
This PR is an attempt to utilise the
DefaultReplayBreadcrumbConverterby ensuring that our breadcrumbs contain all the data properties it's expecting.Additional comments
If we eventually try to implement this for iOS, iOS looks for slightly different field names