Skip to content

Conversation

@jamescrosswell
Copy link
Collaborator

Resolves #4802:

Basically done here:

<!-- Dependencies for AndroidMavenLibrary references
Matching what was shipped in the 10.0.100 workloads to avoid NU1608 warnings
-->
<ItemGroup Condition="$(TargetFramework.StartsWith('net10'))">
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.9.2.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Common.Java8" Version="2.9.2.1" />
<!-- MAUI 10 references this version indirectly via Xamarin.AndroidX.SwipeRefreshLayout -->
<PackageReference Include="Xamarin.AndroidX.Core" Version="1.17.0" />
<!-- We have a dependency on 1.9.24 from here:
https://github.com/getsentry/sentry-java/blob/604a2616bebd80ea051cdcec916aa052b509c5a8/buildSrc/src/main/java/Config.kt#L6-L7
... but there's no NuGet package for that version. This version has been selected to
match the version that was available when net10.0 was released -->
<PackageReference Include="Xamarin.Kotlin.StdLib.Jdk8" Version="2.2.21" />
</ItemGroup>

Note

I tried bumping Xamarin.AndroidX.Lifecycle.Common.Java8 and Xamarin.AndroidX.Lifecycle.Process to 2.10.0 but that gives us dependency conflicts in our Sentry.Maui package. It might be possible with a bit of sleuthing to work out where those come from (would have to be from the <UseMaui>true</UseMaui> include... so somewhere in the MS target files) but I think the fact that it breaks our builds is evidence enough that it's not the right version to reference so I left it at 2.9.2.1.

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.88%. Comparing base (5df4eed) to head (b8f9a4e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4876   +/-   ##
=======================================
  Coverage   73.87%   73.88%           
=======================================
  Files         494      494           
  Lines       17868    17868           
  Branches     3509     3509           
=======================================
+ Hits        13200    13201    +1     
  Misses       3808     3808           
+ Partials      860      859    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Dependencies ⬆️

Deps

  • chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.20 and 8.4.0 by jamescrosswell in #4876
  • chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.20 and 8.4.0 by jamescrosswell in #4876

🤖 This preview updates automatically when you update the PR.

@jamescrosswell jamescrosswell marked this pull request as ready for review February 4, 2026 00:36
@jamescrosswell jamescrosswell changed the title chore: Ensure appropriate Maven references for net10-android targets chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.21 and 8.4.0 Feb 6, 2026
@jamescrosswell jamescrosswell changed the title chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.21 and 8.4.0 chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.20 and 8.4.0 Feb 10, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@jamescrosswell jamescrosswell merged commit f95f266 into main Feb 10, 2026
31 checks passed
@jamescrosswell jamescrosswell deleted the maven-references-net10 branch February 10, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Verify we have the most appropriate transient dependencies for .net SDK 10.0.100

2 participants