-
-
Notifications
You must be signed in to change notification settings - Fork 229
chore(deps): Bumped Xamarin.AndroidX.Lifecycle.Common.Java8 and CommunityToolkit.Mvvm to 2.2.20 and 8.4.0 #4876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Sentry.Maui.CommunityToolkit.Mvvm/Sentry.Maui.CommunityToolkit.Mvvm.csproj
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4876 +/- ##
=======================================
Coverage 73.87% 73.88%
=======================================
Files 494 494
Lines 17868 17868
Branches 3509 3509
=======================================
+ Hits 13200 13201 +1
Misses 3808 3808
+ Partials 860 859 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9b405dd to
cb41e0c
Compare
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Dependencies ⬆️Deps
🤖 This preview updates automatically when you update the PR. |
52049a1 to
3c1fab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Resolves #4802:
Basically done here:
sentry-dotnet/src/Sentry.Bindings.Android/Sentry.Bindings.Android.csproj
Lines 48 to 61 in 9b405dd
Note
I tried bumping
Xamarin.AndroidX.Lifecycle.Common.Java8andXamarin.AndroidX.Lifecycle.Processto2.10.0but that gives us dependency conflicts in our Sentry.Maui package. It might be possible with a bit of sleuthing to work out where those come from (would have to be from the<UseMaui>true</UseMaui>include... so somewhere in the MS target files) but I think the fact that it breaks our builds is evidence enough that it's not the right version to reference so I left it at2.9.2.1.