Skip to content

test: add breaking electron-vite esm example#1354

Open
biw wants to merge 1 commit intogetsentry:masterfrom
biw:biw/fix-esm-sentry
Open

test: add breaking electron-vite esm example#1354
biw wants to merge 1 commit intogetsentry:masterfrom
biw:biw/fix-esm-sentry

Conversation

@biw
Copy link
Copy Markdown

@biw biw commented Apr 15, 2026

Adds a new examples/electron-vite-esm fixture to reproduce the current ESM failure path in an electron-vite app.

This PR:

  • adds a minimal Electron + Vite + Vue example with "type": "module"
  • initializes Sentry in both the Electron main process and renderer
  • loads electron-squirrel-startup via createRequire(import.meta.url) in the ESM main entry
  • adds an e2e test that runs with skipEsmAutoTransform: true and asserts the captured fatal event

This example will fail until open-telemetry/opentelemetry-js#6590 is merged in, but I think there's value in adding it here since #1043 and #1007 seem like the same underlying issue. Maybe after open-telemetry/opentelemetry-js#6590 is merged in?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Internal Changes 🔧

  • Add breaking electron-vite esm example by biw in #1354

🤖 This preview updates automatically when you update the PR.

@sdk-maintainer-bot
Copy link
Copy Markdown

This PR has been automatically closed. The referenced issue is already assigned to someone else.

If you believe this assignment is outdated, please comment on the issue to discuss before opening a new PR.

Please review our contributing guidelines for more details.

@biw
Copy link
Copy Markdown
Author

biw commented Apr 15, 2026

@timfish maybe I shouldn't have referenced #1007 in my PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants