fix: Truncate minidump extra parameters when updating#1361
Merged
Conversation
andreiborza
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
electronMinidumpIntegration, we store JSON stringified scope in what Crashpad calls "extra parameters". Because these parameters are limited in length, we save them to multiple parameters labelledsentry__N. On ingestion, Relay concatenates these parameters to get the JSON payload.This PR fixes a potential bug if the JSON payload ever gets shorter and extra parameters are left with Crashpad containing the end of the previous JSON in them.