[skill-drift] fix(sentry-flutter-sdk): document enableNewTraceOnNavigation default change to false#106
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
…change to false Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| |-------|----------| | ||
| | No transactions in Sentry | Confirm `tracesSampleRate > 0`; set to `1.0` to see all during debugging | | ||
| | Navigation not tracked | Add `SentryNavigatorObserver()` to `navigatorObservers`; name all routes | | ||
| | Traces not being connected across navigations | `enableNewTraceOnNavigation` defaults to `false` since 9.19.0 — set it to `true` to generate a fresh trace on each navigation event | |
There was a problem hiding this comment.
Bug: The troubleshooting guide for enableNewTraceOnNavigation has a misleading problem description that contradicts the suggested solution.
Severity: LOW
Suggested Fix
Update the problem description in the troubleshooting table to be more accurate. Instead of "Traces not being connected across navigations", use a clearer phrase like "Navigation events not generating separate traces" or "All navigation appearing in a single trace" to accurately reflect the issue that setting enableNewTraceOnNavigation: true resolves.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-flutter-sdk/references/tracing.md#L472
Potential issue: The troubleshooting documentation for `enableNewTraceOnNavigation`
contains a logical contradiction. The problem is described as "Traces not being
connected across navigations", which implies traces are fragmented. However, the
suggested solution is to set `enableNewTraceOnNavigation: true`, which is the setting
that explicitly creates a new, separate trace for each navigation event. This action
would exacerbate, not fix, the problem as described. While the intended audience (users
upgrading from a previous version) might understand the goal, the problem description is
misleading and will likely confuse users unfamiliar with the history of this setting.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK Changes
The following PR was merged to
getsentry/sentry-dartthat affects thesentry-flutter-sdkskill:enh(navigator-observer): make new trace id on navigation opt-in instead of opt-out(enh(navigator-observer): make new trace id on navigation opt-in instead of opt-out sentry-dart#3657)Changes Made
enableNewTraceOnNavigation: falsewith explanatory comment to theSentryNavigatorObservercode example inreferences/tracing.md, documenting the new default and noting the change fromtrue→falseinsentry_flutter9.19.0enableNewTraceOnNavigation: trueVerified Against
#3657)enableNewTraceOnNavigation = falseas the new default inSentryNavigatorObserverconstructorNote
🔒 Integrity filter blocked 11 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: