[skill-drift] fix(sentry-react-native-sdk): add includeWebFeedback Metro option and rage tap detection docs#108
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
… rage tap detection docs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
||
| ### Rage Tap Detection (TouchEventBoundary) | ||
|
|
||
| `TouchEventBoundary` (wraps your app root) includes built-in rage tap detection. When a user taps the same element 3+ times within 1 second, a `ui.multiClick` breadcrumb is emitted and shown on the replay timeline. Configure via props: |
There was a problem hiding this comment.
Bug: The documentation for rage tap detection incorrectly specifies the breadcrumb type as ui.multiClick instead of ui.frustration.
Severity: LOW
Suggested Fix
Update the documentation in SKILL.md to replace the incorrect breadcrumb type ui.multiClick with the correct type, ui.frustration, for rage tap detection.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-react-native-sdk/SKILL.md#L734
Potential issue: The documentation at `skills/sentry-react-native-sdk/SKILL.md`
incorrectly states that rage tap detection in the React Native SDK emits a breadcrumb
with the type `ui.multiClick`. The correct breadcrumb type for this feature is
`ui.frustration`. The `ui.multiClick` type is associated with rage-clicks in the web
SDK, not rage-taps in the React Native SDK. This discrepancy can cause confusion for
developers trying to use or filter these breadcrumbs.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK Changes
The following PRs were merged to
getsentry/sentry-react-nativethat affect thesentry-react-native-sdkskill:feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle(feat(core): Add includeFeedback Metro option to exclude feedback widget from bundle sentry-react-native#6025)feat(core): Add rage tap detection with ui.frustration breadcrumbs(feat(core): Add rage tap detection with ui.frustration breadcrumbs sentry-react-native#5992)Changes Made
includeWebFeedbackMetro option: Updated thewithSentryConfig()call in the vanilla RN setup path to show bothincludeWebReplayandincludeWebFeedbackoptions as commented-out examples, so developers know they can opt out of including the feedback widget in native bundlesTouchEventBoundaryProps:enableRageTapDetection(default:true),rageTapThreshold(default: 3), andrageTapTimeWindow(default: 1000ms)Verified Against
#6025and#5992)Note
🔒 Integrity filter blocked 11 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: