[skill-drift] fix(sentry-node-sdk,sentry-react-sdk): document ignoreSpans attributes field#109
Open
github-actions[bot] wants to merge 1 commit intomainfrom
Open
Conversation
…s field for attribute-based span filtering Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment on lines
+459
to
+461
| "http.url": "/health", // string = substring match | ||
| "http.status_code": 200, // non-string = strict equality | ||
| }, |
There was a problem hiding this comment.
Bug: The Node SDK documentation incorrectly states the attributes feature in ignoreSpans requires "SDK ≥9.x", while the React SDK documentation correctly states "SDK ≥10.6.0".
Severity: MEDIUM
Suggested Fix
Update the version requirement in the Node SDK documentation at skills/sentry-node-sdk/references/tracing.md from ≥9.x to ≥10.6.0 to match the React SDK documentation and the actual feature release version. This ensures consistency and prevents user confusion.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: skills/sentry-node-sdk/references/tracing.md#L459-L461
Potential issue: The documentation for the Node SDK incorrectly states that the
`attributes` field in the `ignoreSpans` configuration is available in SDK versions
`≥9.x`. However, the corresponding React SDK documentation specifies version `≥10.6.0`.
Since both SDKs share the same underlying `@sentry/core` package where this feature is
implemented, the versions should be consistent. This discrepancy will cause users of the
Node SDK on a version like `9.x` or `10.5.0` to attempt to use a feature that doesn't
exist in their version, leading to silent failure of the span filtering and user
confusion.
Also affects:
skills/sentry-react-sdk/references/tracing.md:1268~1271
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK Changes
The following PR was merged to
getsentry/sentry-javascriptthat affects multiple JS SDK skills:ignoreSpanssentry-javascript#20512 —feat(core): Support attribute matching in ignoreSpans(feat(core): Support attribute matching inignoreSpanssentry-javascript#20512)Changes Made
sentry-node-sdkreferences/tracing.md: Expanded theignoreSpanssection to show the new object form with anattributesfield, including examples of string (substring match) and non-string (strict equality) attribute matchingsentry-react-sdkreferences/tracing.md: Added anattributesentry to the existingignoreSpansobject-form examples with SDK version note (≥10.6.0)Verified Against
#20512)attributesfield toignoreSpansobject entries per the [ignoreSpans spec]((develop.sentry.dev/redacted)Note
🔒 Integrity filter blocked 11 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: