Skip to content

[skill-drift] fix(sentry-node-sdk,sentry-react-sdk): document ignoreSpans attributes field#109

Open
github-actions[bot] wants to merge 1 commit intomainfrom
skill-drift/js-ignorespans-attributes-ab57c0018f8bbe70
Open

[skill-drift] fix(sentry-node-sdk,sentry-react-sdk): document ignoreSpans attributes field#109
github-actions[bot] wants to merge 1 commit intomainfrom
skill-drift/js-ignorespans-attributes-ab57c0018f8bbe70

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

SDK Changes

The following PR was merged to getsentry/sentry-javascript that affects multiple JS SDK skills:

Changes Made

  • sentry-node-sdk references/tracing.md: Expanded the ignoreSpans section to show the new object form with an attributes field, including examples of string (substring match) and non-string (strict equality) attribute matching
  • sentry-react-sdk references/tracing.md: Added an attributes entry to the existing ignoreSpans object-form examples with SDK version note (≥10.6.0)

Verified Against

  • SDK source: getsentry/sentry-javascript@develop (PR #20512)
  • The PR adds optional attributes field to ignoreSpans object entries per the [ignoreSpans spec]((develop.sentry.dev/redacted)

Note

🔒 Integrity filter blocked 11 items

The following items were blocked because they don't meet the GitHub integrity level.

  • #282 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #7800 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #1168 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #893 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #4793 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #6140 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #6139 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #6138 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #2940 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #2938 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
  • #83 list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by SDK Skill Drift Detector · ● 906.2K ·

  • expires on May 11, 2026, 1:23 PM UTC

…s field for attribute-based span filtering

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Comment on lines +459 to +461
"http.url": "/health", // string = substring match
"http.status_code": 200, // non-string = strict equality
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The Node SDK documentation incorrectly states the attributes feature in ignoreSpans requires "SDK ≥9.x", while the React SDK documentation correctly states "SDK ≥10.6.0".
Severity: MEDIUM

Suggested Fix

Update the version requirement in the Node SDK documentation at skills/sentry-node-sdk/references/tracing.md from ≥9.x to ≥10.6.0 to match the React SDK documentation and the actual feature release version. This ensures consistency and prevents user confusion.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: skills/sentry-node-sdk/references/tracing.md#L459-L461

Potential issue: The documentation for the Node SDK incorrectly states that the
`attributes` field in the `ignoreSpans` configuration is available in SDK versions
`≥9.x`. However, the corresponding React SDK documentation specifies version `≥10.6.0`.
Since both SDKs share the same underlying `@sentry/core` package where this feature is
implemented, the versions should be consistent. This discrepancy will cause users of the
Node SDK on a version like `9.x` or `10.5.0` to attempt to use a feature that doesn't
exist in their version, leading to silent failure of the span filtering and user
confusion.

Also affects:

  • skills/sentry-react-sdk/references/tracing.md:1268~1271

Did we get this right? 👍 / 👎 to inform future reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants