Conversation
…7.35 @tanstack/start-plugin-core@1.168.0 (published 2026-04-24) declares @rsbuild/core as a peer dependency but statically imports it at the top of dist/esm/rsbuild/planning.js. When building with vite (not rsbuild), Node fails to resolve the import and vite.config.ts load crashes before any test runs. Pin via pnpm.overrides until TanStack fixes the upstream package. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Pins a broken transitive dependency in the tanstackstart-react E2E test application to restore CI stability after an upstream release introduced a missing peer dependency at runtime.
Changes:
- Add a
pnpm.overridesentry in thetanstackstart-reacttest app to pin@tanstack/start-plugin-coreto1.167.35.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tanstack/start-plugin-core@1.168.0was published at2026-04-24T01:28Zand broke thetanstackstart-reactE2E build on every branch 😡I had a clanker pin it temporarily, to unblock the current branches.