feat(sveltekit): Support span streaming in svelteKitSpansEnhancement integration#20496
Open
nicohrubec wants to merge 1 commit intodevelopfrom
Open
feat(sveltekit): Support span streaming in svelteKitSpansEnhancement integration#20496nicohrubec wants to merge 1 commit intodevelopfrom
svelteKitSpansEnhancement integration#20496nicohrubec wants to merge 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 488e1e1. Configure here.
| expect(span.attributes?.[SEMANTIC_ATTRIBUTE_SENTRY_OP]).toBe('custom.op'); | ||
| expect(span.attributes?.[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]).toBe('auto.http.sveltekit'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing integration or E2E test for feat PR
Low Severity
This is a feat PR that only includes unit tests. Per the project review rules, feat PRs are expected to include at least one integration or E2E test. There is an existing E2E test application at dev-packages/e2e-tests/test-applications/sveltekit-2-kit-tracing/ that could potentially be extended to verify span streaming behavior end-to-end. Flagging this because it was mentioned in the project rules file.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 488e1e1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
processSpanhook alongside the existingpreprocessEventso SvelteKit-emitted spans get enhanced with the rightsentry.op/sentry.originin span-streaming mode. The new_enhanceKitSpanStreamedmirrors_enhanceKitSpanfor streamed spans.Refactored the lookup logic into a shared helper and added span streaming unit tests (that also exactly mirror the existing unit tests for non-streamed spans).
Closes #20364