feat(node): vendor ioredis, redis instrumentaitons#20510
Draft
feat(node): vendor ioredis, redis instrumentaitons#20510
Conversation
Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency. A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support. See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor in the Redis and IORedis instrumentation code and unit tests, and update everything in Sentry to use our vendored code instead of the external dependency.
A subsequent commit will update the node-redis instrumentation to use its recently-added Diagnostics Channel support.
See: https://github.com/redis/node-redis/blob/master/docs/diagnostics-channel.md
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Closes #issue_link_here