Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/profiling-node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,10 @@ Once you run `node esbuild.serverless.js` esbuild wil bundle and output the file
the binaries will be copied. This is wasteful as you will likely only need one of these libraries to be available during
runtime.

To prune the other libraries, profiling-node ships with a small utility script that helps you prune unused binaries. The
script can be invoked via `sentry-prune-profiler-binaries`:
> **Deprecation notice:** This script will be removed in the next major version. If you depend on it, please comment on
> [this issue](https://github.com/getsentry/sentry-javascript/issues/20567).

To prune the other libraries, profiling-node ships with a small utility script that helps you prune unused binaries:

```bash
npx --package=@sentry/profiling-node sentry-prune-profiler-binaries
Expand Down
4 changes: 4 additions & 0 deletions packages/profiling-node/scripts/prune-profiler-binaries.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ Arguments:\n
process.exit(0);
}

console.warn(
'[Sentry] Warning: This script will be removed in the next major version. See: https://github.com/getsentry/sentry-javascript/issues/20567',
);

const ARGV_ERRORS = [];

const NODE_TO_ABI = {
Expand Down
6 changes: 3 additions & 3 deletions packages/remix/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,13 @@ Sentry.captureEvent({
The Remix SDK provides a script that automatically creates a release and uploads sourcemaps. To generate sourcemaps with
Remix, you need to call `remix build` with the `--sourcemap` option.

On release, call `sentry-upload-sourcemaps` to upload source maps and create a release:
On release, call the upload sourcemaps command to upload source maps and create a release:

```bash
npx --package=@sentry/remix sentry-upload-sourcemaps
npx @sentry/remix --upload-sourcemaps
```

To see more details on how to use the command, call `npx --package=@sentry/remix sentry-upload-sourcemaps --help`.
To see more details on how to use the command, run `npx @sentry/remix --upload-sourcemaps --help`.

For more advanced configuration,
[directly use `sentry-cli` to upload source maps.](https://github.com/getsentry/sentry-cli).
12 changes: 11 additions & 1 deletion packages/remix/scripts/sentry-upload-sourcemaps.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ const DEFAULT_URL_PREFIX = '~/build/';
const DEFAULT_BUILD_PATH = 'public/build';

const argv = yargs(process.argv.slice(2))
.option('upload-sourcemaps', {
type: 'boolean',
describe: 'Specifies the upload sourcemaps command. Recommended for forward compatibility.',
})
.option('release', {
type: 'string',
describe:
Expand Down Expand Up @@ -48,7 +52,7 @@ const argv = yargs(process.argv.slice(2))
default: true,
})
.usage(
'Usage: $0\n' +
'Usage: npx @sentry/remix --upload-sourcemaps\n' +
' [--release RELEASE]\n' +
' [--org ORG]\n' +
' [--project PROJECT]\n' +
Expand All @@ -64,6 +68,12 @@ const argv = yargs(process.argv.slice(2))
)
.wrap(120).argv;

if (!argv.uploadSourcemaps) {
process.stderr.write(
'[Sentry] Warning: Calling this script without --upload-sourcemaps is deprecated. Use: `npx @sentry/remix --upload-sourcemaps`\n',
);
}
Comment thread
cursor[bot] marked this conversation as resolved.

const buildPath = argv.buildPath || DEFAULT_BUILD_PATH;
const urlPrefix = argv.urlPrefix || DEFAULT_URL_PREFIX;

Expand Down
Loading