Skip to content

test(node): Make mongodb tests less flaky #20598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mydea wants to merge 1 commit into from
+14 −101
Closed

test(node): Make mongodb tests less flaky #20598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 14 additions & 101 deletions dev-packages/node-integration-tests/suites/tracing/mongodb/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,51 +17,17 @@ describe('MongoDB experimental Test', () => {
cleanupChildProcesses();
});

/**
* Assert the operations we run in `scenario.js` are present. We intentionally
* do not match the full span list: wire-protocol handshakes (`isMaster` vs
* `hello`) and session cleanup vary by driver / server and are a common
* source of flakes in CI (see https://github.com/getsentry/sentry-javascript/issues/20424).
*/
const EXPECTED_TRANSACTION = {
transaction: 'Test Transaction',
spans: [
spans: expect.arrayContaining([
expect.objectContaining({
data: {
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
'db.name': 'admin',
'db.mongodb.collection': '$cmd',
'db.operation': 'isMaster',
'db.connection_string': expect.any(String),
'net.peer.name': expect.any(String),
'net.peer.port': expect.any(Number),
'db.statement':
'{"ismaster":"?","client":{"driver":{"name":"?","version":"?"},"os":{"type":"?","name":"?","architecture":"?","version":"?"},"platform":"?"},"compression":[],"helloOk":"?"}',
'otel.kind': 'CLIENT',
},
description:
'{"ismaster":"?","client":{"driver":{"name":"?","version":"?"},"os":{"type":"?","name":"?","architecture":"?","version":"?"},"platform":"?"},"compression":[],"helloOk":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
'db.name': 'admin',
'db.mongodb.collection': '$cmd',
'db.operation': 'isMaster',
'db.connection_string': expect.any(String),
'net.peer.name': expect.any(String),
'net.peer.port': expect.any(Number),
'db.statement':
'{"ismaster":"?","client":{"driver":{"name":"?","version":"?"},"os":{"type":"?","name":"?","architecture":"?","version":"?"},"platform":"?"},"compression":[],"helloOk":"?"}',
'otel.kind': 'CLIENT',
},
description:
'{"ismaster":"?","client":{"driver":{"name":"?","version":"?"},"os":{"type":"?","name":"?","architecture":"?","version":"?"},"platform":"?"},"compression":[],"helloOk":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
data: expect.objectContaining({
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
Expand All @@ -73,13 +39,13 @@ describe('MongoDB experimental Test', () => {
'net.peer.port': expect.any(Number),
'db.statement': '{"title":"?","_id":{"_bsontype":"?","id":"?"}}',
'otel.kind': 'CLIENT',
},
}),
description: '{"title":"?","_id":{"_bsontype":"?","id":"?"}}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
data: expect.objectContaining({
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
Expand All @@ -91,13 +57,13 @@ describe('MongoDB experimental Test', () => {
'net.peer.port': expect.any(Number),
'db.statement': '{"title":"?"}',
'otel.kind': 'CLIENT',
},
}),
description: '{"title":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
data: expect.objectContaining({
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
Expand All @@ -109,65 +75,12 @@ describe('MongoDB experimental Test', () => {
'net.peer.port': expect.any(Number),
'db.statement': '{"title":"?"}',
'otel.kind': 'CLIENT',
},
description: '{"title":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
'db.name': 'admin',
'db.mongodb.collection': 'movies',
'db.operation': 'find',
'db.connection_string': expect.any(String),
'net.peer.name': expect.any(String),
'net.peer.port': expect.any(Number),
'db.statement': '{"title":"?"}',
'otel.kind': 'CLIENT',
},
description: '{"title":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
'db.name': 'admin',
'db.mongodb.collection': 'movies',
'db.operation': 'find',
'db.connection_string': expect.any(String),
'net.peer.name': expect.any(String),
'net.peer.port': expect.any(Number),
'db.statement': '{"title":"?"}',
'otel.kind': 'CLIENT',
},
}),
description: '{"title":"?"}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
expect.objectContaining({
data: {
'sentry.origin': 'auto.db.otel.mongo',
'sentry.op': 'db',
'db.system': 'mongodb',
'db.name': 'admin',
'db.mongodb.collection': '$cmd',
'db.connection_string': expect.any(String),
'net.peer.name': expect.any(String),
'net.peer.port': expect.any(Number),
'db.statement': '{"endSessions":[{"id":{"_bsontype":"?","sub_type":"?","position":"?","buffer":"?"}}]}',
'otel.kind': 'CLIENT',
},
description: '{"endSessions":[{"id":{"_bsontype":"?","sub_type":"?","position":"?","buffer":"?"}}]}',
op: 'db',
origin: 'auto.db.otel.mongo',
}),
],
]),
};

test('CJS - should auto-instrument `mongodb` package.', async () => {
Expand Down
Loading