feat(solidstart): Auto-wire orchestrion build-time instrumentation - #22827
feat(solidstart): Auto-wire orchestrion build-time instrumentation#22827chargome wants to merge 4 commits into
Conversation
`withSentry()` now adds the orchestrion bundler plugin to the SolidStart/Nitro build automatically, gated on the shared `buildTimeInstrumentation` opt-out. Follows Nuxt's `setupOrchestrion` pattern: push the rollup code transform and force-inline `INSTRUMENTED_MODULE_NAMES` into Nitro externals. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Extend the solidstart e2e app with mysql/ioredis routes and a Docker-backed test asserting the `auto.db.orchestrion.*` spans, proving the auto-wiring. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
buglinger run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 16dd435. Configure here.
| if (addBuildTimeInstrumentation) { | ||
| (rollupConfig as unknown as RollupConfig).plugins.push( | ||
| sentryOrchestrionPlugin({ buildTimeInstrumentation: sentryPluginOptions.buildTimeInstrumentation }), | ||
| ); |
There was a problem hiding this comment.
Unguarded double type assertion
Low Severity
Flagged because it was mentioned in the PR review rules file: new SDK source uses an as unknown as double-cast with no comment explaining why a safer type isn’t possible. This violates the rule that every new any / as any / as unknown as / non-null assertion needs that justification comment.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 16dd435. Configure here.
Hoist the `rollup:before` config cast into one narrowing with a justification comment, replacing the duplicate double-cast. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
withSentry()now adds the orchestrion bundler plugin to the SolidStart/Nitro build automatically, so instrumented DB drivers getdiagnostics_channelpublishers injected at build time with no manual setup. Follows Nuxt'ssetupOrchestrionpattern and is gated on the sharedbuildTimeInstrumentationopt-out.The externals-inlining is set statically on the returned
serverconfig (not in a hook) because externalization must land before Rollup normalizesexternal.Closes #22687