ref(node)!: Remove @opentelemetry/instrumentation dependency - #22843
Draft
andreiborza wants to merge 1 commit into
Draft
ref(node)!: Remove @opentelemetry/instrumentation dependency#22843andreiborza wants to merge 1 commit into
@opentelemetry/instrumentation dependency#22843andreiborza wants to merge 1 commit into
Conversation
`@sentry/node` was the last package holding `@opentelemetry/instrumentation`. All instrumentation is now channel-based via orchestrion, so the surface this dependency backed is dead or a no-op: - `generateInstrumentOnce` (and the framework re-exports) had no call sites. - `ensureIsWrapped`'s shimmer-based check can no longer detect channel-based express/koa/hapi, so its warning and the `missing_instrumentation` context were removed, along with the `disableInstrumentationWarnings` option and the `MissingInstrumentationContext` type. - The `@sentry/node/import` ESM hook now only registers the orchestrion diagnostics-channel injection; the legacy iitm `@sentry/node/loader` entry was removed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
Author
|
batman begin |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5681acc. Configure here.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
@opentelemetry/instrumentationdependency from@sentry/node, the last package that still declared it.generateInstrumentOnceexport (from@sentry/nodeand the framework SDKs that re-exported it).ensureIsWrappedand themissing_instrumentationcontext it set, plus the now-vestigialdisableInstrumentationWarningsoption andMissingInstrumentationContexttype from@sentry/core.InstrumentationConfigtype in the two files that used it.@sentry/node/importan orchestrion-only diagnostics-channel hook and remove the legacy iitm@sentry/node/loaderentry point.otelvariant of themakeOtelLoadersbuild util (node was its only user); thesentry-nodevariant is unchanged.Why
All instrumentation is now channel-based via orchestrion, so nothing in
@sentry/nodeuses@opentelemetry/instrumentationanymore.generateInstrumentOncehad no remaining call sites, andensureIsWrapped's shimmer-based detection can no longer see channel-based express/koa/hapi, so its warning only produced false negatives. The@sentry/node/importhook already registered the orchestrion injection; the iitmregister()call it also did instrumented nothing. This is a breaking change, made as part of the v11 major.