fix: Fix double counting of Faraday spans when using net_http_persistent adapter - #3017
Open
robertjlooby wants to merge 3 commits into
Open
fix: Fix double counting of Faraday spans when using net_http_persistent adapter#3017robertjlooby wants to merge 3 commits into
robertjlooby wants to merge 3 commits into
Conversation
solnic
reviewed
Jul 29, 2026
solnic
left a comment
solnic
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Would you mind resolving conflicts (probably it's going to be easier to just reapply commits on a freshly reset branch and f-push) and also see my question re test adapter 😄
| gem "yard" | ||
| gem "webrick" | ||
| gem "faraday" | ||
| gem "faraday-net_http_persistent" |
Collaborator
There was a problem hiding this comment.
Can we not introduce this dep and use a test adapter that would reproduce the issue instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
net_http_persistentFaraday adapter (https://github.com/lostisland/faraday-net_http_persistent) with thefaradaypatch, the spans/breadcrumbs are double counted.