Skip to content

Conversation

@bitsandfoxes
Copy link
Contributor

This is similar to #2527
If running the game hangs (i.e. on Linux during startup) the state has to be reset and the tests rerun.

This wraps the existing logic in a max-try = 3 and resets the AppDataDir.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Write-Log "Will retry..."
continue
}
throw
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hung process not killed when Player.log missing during retry

Medium Severity

When the game hangs during startup (the exact scenario this PR targets), the AppDataDir has been cleaned at the start of the attempt and the hung process never recreated Player.log. Get-Content on the missing file throws a terminating error (due to $ErrorActionPreference = "Stop"), which propagates out of RunTest before reaching Stop-Process -Force. The finally block in RunTest only writes ::endgroup:: and doesn't clean up the process. The retry loop catches the exception and starts a new attempt, but the old hung process is still running. Before this PR there was no retry so the script would just exit; now zombie processes accumulate across retries and could interfere with subsequent attempts.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant