Skip to content

Conversation

@bitsandfoxes
Copy link
Contributor

The DebugSymbolsTab disables the org slug field when it detects an org auth token via StartsWith("sntrys_"). But token validation and org extraction in sentry-cli consists of three different parts, checking for StartsWith("sntrys_") just being one of them.

This means a token can pass the prefix check yet still fail sentry-cli's own parsing — leaving the user with a disabled org field and no way to provide the org slug as a fallback.

This removes the IsOrgAuthToken() prefix check and the special handling around the org field: no more disabling it, no more info help box, no more error icon. The wizard will still only fill the auth token since it reliably fetches the correct one. But the SDK will no longer hinder users from filling the org field as a fallback.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


Bug Fixes 🐛

  • Remove faulty token validation for symbol upload by bitsandfoxes in #2537

Internal Changes 🔧

  • (deps) Update Cocoa SDK to v9.4.1 by github-actions in #2540

🤖 This preview updates automatically when you update the PR.

@bitsandfoxes bitsandfoxes merged commit 2e40558 into main Feb 12, 2026
30 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/cli-auth-org branch February 12, 2026 10:25
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

var isOrgAuthToken = cliOptions.IsOrgAuthToken();
if (isOrgAuthToken)
{
EditorGUILayout.HelpBox(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Org Slug error icon removed instead of simplified

Medium Severity

The Org Slug field's GUIContent lost its ErrorIcon argument entirely. The Auth Token and Project Name fields both still show SentryWindow.ErrorIcon when UploadSymbols is enabled and the value is empty, but the Org Slug field no longer does. The old code conditionally showed the icon via !isOrgAuthToken; removing the org-auth-token logic means the condition simplifies to cliOptions.UploadSymbols && string.IsNullOrWhiteSpace(cliOptions.Organization), but instead the whole icon expression was dropped.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants