Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sourcemaps/tools/sentry-cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export async function configureSentryCLI(
const packageDotJson = await getPackageDotJson();

await installPackage({
packageName: '@sentry/cli@^2',
packageName: '@sentry/cli@2.58.6',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also allow newer versions, e.g. if we ever have a 2.58.7?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact version pin prevents future patch updates

Medium Severity

Changing packageName from @sentry/cli@^2 to @sentry/cli@2.58.6 pins users to an exact version. The packageName is passed directly to the package manager install command, so 2.58.6 without a ^ or ~ prefix will save an exact version in the user's package.json. This prevents users from automatically receiving future security patches or bug fixes to @sentry/cli. Using @sentry/cli@~2.58.6 or @sentry/cli@^2.58.6 would ensure users get at least 2.58.6 while still receiving future compatible updates.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit be21e08. Configure here.

alreadyInstalled: hasPackageInstalled('@sentry/cli', packageDotJson),
});

Expand Down
2 changes: 1 addition & 1 deletion src/sourcemaps/tools/wrangler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ Otherwise, let's proceed with the Wrangler setup.`,
}

await installPackage({
packageName: '@sentry/cli@^2',
packageName: '@sentry/cli@2.58.6',
alreadyInstalled: hasPackageInstalled(
'@sentry/cli',
await getPackageDotJson(),
Expand Down
Loading