Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/sentry/api/serializers/models/seer_night_shift_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class SeerNightShiftRunResponse(TypedDict):
dateAdded: str
extras: dict[str, Any]
errorMessage: str | None
kinds: dict[str, Any]
results: list[SeerNightShiftRunResultResponse]
issues: list[SeerNightShiftRunIssueResponse]
triageStrategy: str
Expand All @@ -61,12 +62,15 @@ def serialize(
r for r in all_results if r.kind == NightShiftRunResultKind.AGENTIC_TRIAGE
]
extras = obj.extras or {}
kinds_state = extras.get("kinds") or {}
triage_state = kinds_state.get(NightShiftRunResultKind.AGENTIC_TRIAGE.value) or {}
return {
"id": str(obj.id),
"dateAdded": obj.date_added.isoformat(),
"extras": extras,
# Legacy alias: error_message lives in extras now.
"errorMessage": extras.get("error_message"),
"kinds": kinds_state,
# Legacy alias: prefer per-kind triage error, fall back to flat extras.
"errorMessage": triage_state.get("error_message") or extras.get("error_message"),
"results": [_serialize_result(r) for r in all_results],
"issues": [_serialize_legacy_issue(r) for r in triage_results],
# Match the pre-migration column behavior: always "agentic_triage"
Expand Down
2 changes: 2 additions & 0 deletions src/sentry/features/temporary.py
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("organizations:seer-explorer-index", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable Seer Night Shift nightly autofix cron
manager.add("organizations:seer-night-shift", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable Seer Night Shift nightly user-feedback summarization
manager.add("organizations:seer-night-shift-feedback-summary", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Display nightshift settings
manager.add("organizations:seer-night-shift-settings", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=True)
# Enable context engine for Seer Agent
Expand Down
22 changes: 21 additions & 1 deletion src/sentry/seer/endpoints/admin_night_shift_trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from sentry.api.base import Endpoint, internal_cell_silo_endpoint
from sentry.api.permissions import StaffPermission
from sentry.tasks.seer.night_shift.cron import (
ALL_NIGHT_SHIFT_KINDS,
SeerNightShiftRunOptionsPartial,
run_night_shift_for_org,
schedule_night_shift,
Expand Down Expand Up @@ -44,6 +45,20 @@ def post(self, request: Request) -> Response:
if max_candidates < 1:
return Response({"detail": "max_candidates must be >= 1"}, status=400)

kinds_raw = request.data.get("kinds")
kinds: list[str]
if kinds_raw is None:
kinds = ["agentic_triage"]
elif not isinstance(kinds_raw, list) or not all(isinstance(k, str) for k in kinds_raw):
return Response({"detail": "kinds must be a list of strings"}, status=400)
elif not kinds_raw:
return Response({"detail": "kinds must not be empty"}, status=400)
else:
unknown = [k for k in kinds_raw if k not in ALL_NIGHT_SHIFT_KINDS]
if unknown:
return Response({"detail": f"unknown kinds: {sorted(set(unknown))}"}, status=400)
kinds = list(kinds_raw)

options: SeerNightShiftRunOptionsPartial = {"source": "manual", "dry_run": dry_run}
if max_candidates is not None:
options["max_candidates"] = max_candidates
Expand All @@ -53,13 +68,18 @@ def post(self, request: Request) -> Response:
else:
run_night_shift_for_org.apply_async(
args=[organization_id],
kwargs={"options": options, "execute_in_task": True},
kwargs={
"kinds": kinds,
"options": options,
"execute_in_task": True,
},
)

return Response(
{
"success": True,
"organization_id": organization_id,
"kinds": kinds,
Comment thread
cursor[bot] marked this conversation as resolved.
"dry_run": dry_run,
"max_candidates": max_candidates,
}
Expand Down
1 change: 1 addition & 0 deletions src/sentry/seer/models/night_shift.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

class NightShiftRunResultKind(models.TextChoices):
AGENTIC_TRIAGE = "agentic_triage"
FEEDBACK_SUMMARY = "feedback_summary"


@cell_silo_model
Expand Down
2 changes: 0 additions & 2 deletions src/sentry/tasks/seer/night_shift/agentic_triage.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ def _triage_candidates(
artifact_schema=_TriageResponse,
)

run.update(extras={**run.extras, "agent_run_id": agent_run_id})

logger.info(
"night_shift.explorer_run_started",
extra={
Expand Down
Loading
Loading