Skip to content

ref(flags): Remove organizations:normalize_segment_names_in_span_enrichment#114809

Open
wedamija wants to merge 1 commit intomasterfrom
flag-cleanup/organizations-normalize-segment-names-in-span-enrichment
Open

ref(flags): Remove organizations:normalize_segment_names_in_span_enrichment#114809
wedamija wants to merge 1 commit intomasterfrom
flag-cleanup/organizations-normalize-segment-names-in-span-enrichment

Conversation

@wedamija
Copy link
Copy Markdown
Member

@wedamija wedamija commented May 4, 2026

The flag scanner classified this as flagpole-disabled. The flag gated the entire _normalize_segment_name helper (early return when False); removes the helper, its call site, unused imports, and the three corresponding tests.

…chment

The flag scanner classified this as flagpole-disabled. The flag gated
the entire _normalize_segment_name helper (early return when False);
removes the helper, its call site, unused imports, and the three
corresponding tests.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@wedamija wedamija requested review from a team as code owners May 4, 2026 23:14
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label May 4, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ae5a9b5. Configure here.

# Enable higher limit for workflows
manager.add("organizations:more-workflows", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Normalize segment names during span enrichment
manager.add("organizations:normalize_segment_names_in_span_enrichment", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dangling comment left after removing feature flag

Low Severity

The comment # Normalize segment names during span enrichment on line 186 was left behind after removing the manager.add("organizations:normalize_segment_names_in_span_enrichment", ...) call it described. It now sits as an orphaned comment between the more-workflows feature and the # Extract on demand metrics comment, which could confuse future readers.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ae5a9b5. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant