ref(flags): Remove organizations:dashboards-starred-reordering (backend)#114817
ref(flags): Remove organizations:dashboards-starred-reordering (backend)#114817
Conversation
The flag scanner classified this as flagpole-disabled. The flag gated new dashboard reordering endpoints and per-user last_visited plumbing. Removes: - OrganizationDashboardsStarredEndpoint + Order endpoint (always 404) - URL routes and imports - features.has() gates in organization_dashboards and organization_dashboard_details (keeps the disabled/else paths) - mostFavorited and user-specific recentlyViewed sort branches - Dashboard serializer per-user last_visited annotation - Tests that exercised the flag-enabled paths Frontend changes ship in a separate PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
github-actions
Bot
added
the
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.40% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2a18f5d. Configure here.
|
|
||
| class DashboardListSerializer(Serializer, DashboardFiltersMixin): | ||
| def get_attrs(self, item_list, user, **kwargs): | ||
| organization = kwargs.get("context", {}).get("organization") |
There was a problem hiding this comment.
Unnecessary prefetch of removed feature's data
Low Severity
The prefetch_related_objects call still includes "dashboardlastvisited_set__member", but the only code that consumed this prefetched data (the per-user last_visited lookup inside the feature flag check) was removed in this same PR. This causes unnecessary database queries—joining DashboardLastVisited and OrganizationMember—on every dashboard list request, with no code ever reading the results.
Reviewed by Cursor Bugbot for commit 2a18f5d. Configure here.
1 participant
The flag scanner classified this as flagpole-disabled. The flag gated new dashboard reordering endpoints and per-user last_visited plumbing.
Removes:
Frontend changes ship in a separate PR.