fix(integrations): Validate integration_id in OrganizationIntegrationBaseEndpoint#114821
Merged
fix(integrations): Validate integration_id in OrganizationIntegrationBaseEndpoint#114821
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
approved these changes
May 5, 2026
| args, kwargs = super().convert_args(request, organization_id_or_slug, *args, **kwargs) | ||
|
|
||
| if integration_id is not None: | ||
| kwargs["integration_id"] = to_valid_int_id( |
Contributor
There was a problem hiding this comment.
is int here integration or integer? might be nice to either spell out integration or remove int (since all our ids minus a few places are integers)
Member
Author
There was a problem hiding this comment.
integer. This is a fancy replacement for the ad hoc int(whatever) calls we have/had sprinkled around.
There are 20+ uses, so probably not renaming in this PR, but it needs to move somewhere more general soon (this sprint would make sense) so we'll address that then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
integration_id should look like a valid int before we treat it as one.
Fixes SENTRY-400N.