Skip to content

feat(search): Add userCount filter key to issue search autocomplete #114823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
isaacwang-sentry wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(search): Add userCount filter key to issue search autocomplete #114823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions static/app/utils/fields/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export enum FieldKey {
TIMESTAMP_TO_HOUR = 'timestamp.to_hour',
TIMES_SEEN = 'timesSeen',
TITLE = 'title',
USER_COUNT = 'userCount',
TOTAL_COUNT = 'total.count',
TRACE = 'trace',
TRACE_PARENT_SPAN = 'trace.parent_span',
Expand Down Expand Up @@ -212,6 +213,7 @@ type ErrorFieldKey =
| FieldKey.STATUS
| FieldKey.SYMBOLICATED_IN_APP
| FieldKey.TIMES_SEEN
| FieldKey.USER_COUNT
| FieldKey.TYPE
| FieldKey.UNREAL_CRASH_TYPE;

Expand Down Expand Up @@ -2141,6 +2143,12 @@ const ERROR_FIELD_DEFINITION: Record<ErrorFieldKey, FieldDefinition> = {
valueType: FieldValueType.NUMBER,
keywords: ['count'],
},
[FieldKey.USER_COUNT]: {
desc: t('Number of unique users affected'),
kind: FieldKind.FIELD,
valueType: FieldValueType.NUMBER,
keywords: ['users', 'affected'],
},
[FieldKey.TYPE]: {
desc: t('Type of event (Errors, transactions, csp and default)'),
kind: FieldKind.FIELD,
Expand Down Expand Up @@ -2761,6 +2769,7 @@ export const ISSUE_PROPERTY_FIELDS: FieldKey[] = [
FieldKey.LAST_SEEN,
FieldKey.RELEASE_STAGE,
FieldKey.TIMES_SEEN,
FieldKey.USER_COUNT,
];

// Should match Snuba columns defined in sentry/snuba/events.py
Expand Down
7 changes: 7 additions & 0 deletions static/app/views/issueList/utils/useFetchIssueTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,13 @@ function builtInIssuesFields({
values: [],
predefined: true,
},
[FieldKey.USER_COUNT]: {
...PREDEFINED_FIELDS[FieldKey.USER_COUNT]!,
name: 'User Count',
isInput: true,
values: [],
predefined: true,
},
[FieldKey.ISSUE_PRIORITY]: {
...PREDEFINED_FIELDS[FieldKey.ISSUE_PRIORITY]!,
name: 'Issue Priority',
Expand Down
Loading