Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
"react-lazyload": "^3.2.1",
"react-mentions": "4.4.10",
"react-popper": "^2.3.0",
"react-router-dom": "6.30.3",
"react-router-dom": "7.14.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuqs adapter uses v6 path incompatible with v7

High Severity

Bumping react-router-dom to v7 without updating the nuqs adapter import path will break URL search params state management. static/app/main.tsx and static/gsAdmin/init.tsx both import from nuqs/adapters/react-router/v6, which is explicitly incompatible with React Router v7. The adapter needs to be changed to nuqs/adapters/react-router/v7.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit cdfd4e5. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry router wrapper uses v6-specific function with v7

High Severity

static/app/main.tsx and static/gsAdmin/init.tsx use wrapCreateBrowserRouterV6 from @sentry/react to instrument the router. With react-router-dom bumped to v7, this needs to be wrapCreateBrowserRouterV7. The v6 wrapper may not correctly instrument the v7 router object, breaking Sentry performance monitoring and transaction tracking.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit cdfd4e5. Configure here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry tracing integration targets wrong router version

Medium Severity

static/app/bootstrap/initializeSdk.tsx uses Sentry.reactRouterV6BrowserTracingIntegration for browser tracing. With react-router-dom bumped to v7, this needs to be Sentry.reactRouterV7BrowserTracingIntegration. While the underlying implementations are similar, using the wrong version-specific integration could result in incorrect route parameterization in traces.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit cdfd4e5. Configure here.

"react-select": "4.3.1",
"react-textarea-autosize": "8.5.7",
"reflux": "0.4.1",
Expand Down
Loading
Loading