Skip to content

fix(replay): use org members endpoint for replay access selector #120585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DominikB2014 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −11
Draft

fix(replay): use org members endpoint for replay access selector #120585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions static/app/views/settings/organizationGeneralSettings/organizationSettingsForm.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,6 @@ describe('OrganizationSettingsForm', () => {
url: '/organizations/org-slug/members/',
body: [{user: UserFixture()}],
});
MockApiClient.addMockResponse({
url: '/organizations/org-slug/users/',
body: [{user: UserFixture()}],
});
onSave.mockReset();
});

Expand Down Expand Up @@ -413,7 +409,7 @@ describe('OrganizationSettingsForm', () => {
it('saves replayAccessMembers when a member is selected', async () => {
const user = UserFixture();
MockApiClient.addMockResponse({
url: `/organizations/${organization.slug}/users/`,
url: `/organizations/${organization.slug}/members/`,
body: [{user}],
});
const replayPutMock = MockApiClient.addMockResponse({
Expand Down
10 changes: 4 additions & 6 deletions static/app/views/settings/organizationGeneralSettings/organizationSettingsForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ import {
getLocalityDataFromOrganization,
shouldDisplayLocalities,
} from 'sentry/utils/cells';
import {useProjectMembersQueryOptions} from 'sentry/utils/members/projectMembers';
import {selectUsersFromMembers} from 'sentry/utils/members/shared';
import {memberUsersQueryOptions} from 'sentry/utils/members/shared';
import {fetchMutation} from 'sentry/utils/queryClient';
import {RequestError} from 'sentry/utils/requestError/requestError';
import {slugify} from 'sentry/utils/slugify';
Expand Down Expand Up @@ -86,10 +85,9 @@ export function ReplayAccessMembersField({
organization: Organization;
}) {
const endpoint = `/organizations/${organization.slug}/`;
const {data: members = [], isPending: fetching} = useQuery({
...useProjectMembersQueryOptions(),
select: resp => selectUsersFromMembers(resp.json),
});
const {data: members = [], isPending: fetching} = useQuery(
memberUsersQueryOptions({orgSlug: organization.slug})
);

@cursor cursor Bot Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member list truncated by pagination

Medium Severity

memberUsersQueryOptions hits the paginated /members/ endpoint and only loads the first page (default 100), with no further pages or server-side search. Orgs larger than that cannot select every member for replayAccessMembers, so some people stay missing from the access list.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 1dfe2b0. Configure here.

const memberOptions = members.map(m => ({value: m.id, label: m.name}));

const replayMutationOpts = mutationOptions({
Expand Down
Loading