feat(pr-iteration): resolve all review comment threads after iteration#120589
Draft
alexsohn1126 wants to merge 4 commits into
Draft
feat(pr-iteration): resolve all review comment threads after iteration#120589alexsohn1126 wants to merge 4 commits into
alexsohn1126 wants to merge 4 commits into
Conversation
Succeeds the 🎉 react step (CW-1398). After an Autofix PR iteration completes, resolve all inline review comment threads that were part of that iteration's feedback, alongside the existing 👀 reaction removal. CW-1688
github-actions
Bot
added
the
Scope: Backend
Fold redundant early-return tests into their twins, add a _run helper, merge overlapping resolve assertions, trim unread fixture fields, and strengthen the pagination test to verify cursor threading. Also type the review-comment fixture as ReviewComment to fix latent mypy errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves all inline review comment threads that were part of an Autofix PR iteration's feedback once the iteration completes, alongside the existing 👀 reaction removal. Succeeds the 🎉 react step (CW-1398).
Uses the scm
resolve_review_threadGraphQL mutation; a single batchedget_pull_request_review_threadsper PR maps comment node ids to threads, dedupes, and resolves each unique unresolved thread once. Gated by the existingorganizations:autofix-pr-iterationflag.Note: resolution is skipped in multi-repo runs (review-comment sources carry no repo, same constraint as the existing 👀 removal).
CW-1688