Start with .to_logger and .to_artifact#120593
Draft
saponifi3d wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
the
Scope: Backend
saponifi3d
force-pushed
the
jcallender/wfe-eval/to-logger
branch
from
July 24, 2026 21:00
e25be81 to
a77c03d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Start improving the to_log methods for the refactor
.to_artifactabstract method to the base, so each eval class provides the flattened results -- this will be re-used if we have evaluation artifacts as well.to_logon the base model