fix(seer): Handle 404 from Seer in get_agent_state_from_pr_id gracefully#120605
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(seer): Handle 404 from Seer in get_agent_state_from_pr_id gracefully#120605sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
NoRetriesRemainingErrorinsentry.tasks.autofix.trigger_pr_iteration_from_review.Previously, when
get_agent_state_from_pr_idcalled the Seer API for a PR not managed by Seer, Seer would correctly return an HTTP 404 Not Found. However,get_agent_state_from_pr_idtreated any HTTP status code >= 400 as a fatalSeerApiError.This caused the
trigger_pr_iteration_from_reviewtask to repeatedly fail and retry until all Celery retries were exhausted, leading to theNoRetriesRemainingError.This fix modifies
src/sentry/seer/agent/client_utils.pyto explicitly check for a 404 status code inget_agent_state_from_pr_id. If a 404 is received, it now returnsNonegracefully, allowing the calling task to proceed without error when a PR is not managed by Seer.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5RXF
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.