fix(api): Validate selected_columns in OrganizationEventsEndpoint for RPC datasets#120607
Draft
sentry[bot] wants to merge 1 commit into
Draft
fix(api): Validate selected_columns in OrganizationEventsEndpoint for RPC datasets#120607sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
OrganizationEventsEndpointwas encounteringSnubaRPCError: code: 400when querying RPC-backed datasets (likeOurLogsorspans) if the client did not provide anyfieldparameters, resulting in an emptyselected_columnslist. Snuba's RPC layer would reject these requests with the message "At least one column must be specified in the request".This fix introduces an explicit validation check within the
flex_time_data_fnanddata_fnfunctions insidepaginator_factoryinsrc/sentry/api/endpoints/organization_events.py. Before callingscoped_dataset.run_table_queryfor RPC datasets, it now verifies thatself.get_field_list(organization, request)returns a non-empty list. If no columns are selected, anInvalidSearchQuery("No columns selected")exception is raised. This aligns the behavior withdiscover.query, providing a more informative and earlier error response to the client.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5RGR
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.