fix(ci): Update tests to seed the correct column for ai_conversations#120608
fix(ci): Update tests to seed the correct column for ai_conversations#120608pbhandari wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e7ce3a1. Configure here.
| organization_id=span["organization_id"], | ||
| project_id=span["project_id"], | ||
| item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN, | ||
| conversation_id=span.get("ai_conversation_id", ""), |
There was a problem hiding this comment.
Test helper mismatches production path
Medium Severity
span_to_trace_item seeds TraceItem.conversation_id from a fabricated ai_conversation_id field and asserts when only gen_ai.conversation.id is present. Production convert_span_to_item still derives the column from that attribute and keeps it, so this rejects valid production-shaped test data and mislabels the attribute as deprecated.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit e7ce3a1. Configure here.
| organization_id=span["organization_id"], | ||
| project_id=span["project_id"], | ||
| item_type=TraceItemType.TRACE_ITEM_TYPE_SPAN, | ||
| conversation_id=span.get("ai_conversation_id", ""), |
There was a problem hiding this comment.
Is it the proper name for the attribute?
There was a problem hiding this comment.
Yeah, I was gonna raise this once I got everything else working. On the protobuf side ai_conversation_id doesn't exist, but conversation_id does (Protobuf Definition) (and that's what the tests rely on).
e7ce3a1 to
2beeffb
Compare
| timestamp.FromMilliseconds(span["start_timestamp_ms"]) | ||
|
|
||
| if "gen_ai.conversation.id" in span.get("data", {}) and "ai_conversation_id" not in span: | ||
| assert False, "gen_ai.conversation.id is deprecated. Use the newer indexed on instead." |
There was a problem hiding this comment.
| assert False, "gen_ai.conversation.id is deprecated. Use the newer indexed on instead." | |
| assert False, "gen_ai.conversation.id is deprecated. Use the newer indexed one instead." |
2 participants
Description
Tests were only seeding the un-indexed
gen_ai.conversation.idfield when running the tests. After merging snuba side perf-improvements in getsentry/snuba#8185; the CI started failing due to us not seeding the right field.This now updates the tests so that we always seed the indexed column; and adds a useful error message if we end up forgetting this.
Original failing CI run: https://sentry.slack.com/archives/CUHS29QJ0/p1784920298033589
Snuba CI has been updated to use the failing test in getsentry/snuba#8221, updating the CI to use this branch temporarily causes the CI to pass in this run.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.