fix(spans): Truncate long strings for fuse.js to prevent Firefox recursion#120617
Draft
sentry[bot] wants to merge 2 commits into
Draft
fix(spans): Truncate long strings for fuse.js to prevent Firefox recursion#120617sentry[bot] wants to merge 2 commits into
sentry[bot] wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JAVASCRIPT-22SP: "InternalError: too much recursion" in Firefox.
This error occurred in
waterfallModel.tsxwhenfuse.jsattempted to build a search index for span data.fuse.jstokenizes strings using regex, and Firefox has a stricter regex call stack limit than other browsers. When span fields likeindexed,tagKeys,tagValues,dataKeys, ordataValuescontained excessively long strings (e.g., raw SQL queries, large JSON blobs, or base64 payloads), the regex operations would cause a stack overflow in Firefox.The solution truncates these strings to a maximum length of 5000 characters before they are passed to
fuse.js. This prevents the recursion error without affecting the actual display or integrity of the span data, as the truncation only applies to the search index.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JAVASCRIPT-22SP
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.