Skip to content

fix(eap-outcomes): Add trace ID and timestamp to dedup key#7915

Merged
untitaker merged 3 commits intomasterfrom
trace-id-dedup
Apr 29, 2026
Merged

fix(eap-outcomes): Add trace ID and timestamp to dedup key#7915
untitaker merged 3 commits intomasterfrom
trace-id-dedup

Conversation

@untitaker
Copy link
Copy Markdown
Member

ref STREAM-881

@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 29, 2026

@untitaker untitaker changed the title fix(eap-outcomes): Add trace ID and timestmap to dedup key fix(eap-outcomes): Add trace ID and timestamp to dedup key Apr 29, 2026
@untitaker untitaker marked this pull request as ready for review April 29, 2026 15:31
@untitaker untitaker requested a review from a team as a code owner April 29, 2026 15:31
@MeredithAnya
Copy link
Copy Markdown
Member

@untitaker can you add

if item_type != TraceItemType::Span {
    return false;
}

in the is_duplicate? I want to see how much that lightens the load on the consumers, since if we can run few consumers we get better deduping

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a6d782a. Configure here.

Comment thread rust_snuba/src/strategies/accepted_outcomes/aggregator.rs
The make_payload_with_item_id test helper was using Default for
item_type (Unspecified), but the new Span-only guard requires
item_type to be Span for deduplication to occur.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@untitaker untitaker enabled auto-merge (squash) April 29, 2026 16:32
@untitaker untitaker merged commit c97c0ea into master Apr 29, 2026
49 checks passed
@untitaker untitaker deleted the trace-id-dedup branch April 29, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants