Skip to content

feat(watermarks): add test for watermarks passing thru PythonAdapter#310

Merged
bmckerry merged 1 commit intomainfrom
ben/test-pythonadapter-watermarks
May 5, 2026
Merged

feat(watermarks): add test for watermarks passing thru PythonAdapter#310
bmckerry merged 1 commit intomainfrom
ben/test-pythonadapter-watermarks

Conversation

@bmckerry
Copy link
Copy Markdown
Member

@bmckerry bmckerry commented May 4, 2026

Ticket: https://linear.app/getsentry/issue/STREAM-508/add-pythonadapter-to-rust-arroyo-watermark-unit-test

This PR adds a test for ensuring that pipeline watermarks and associated commit requests pass through a PythonAdapter step properly.

@bmckerry bmckerry requested a review from a team as a code owner May 4, 2026 19:43
Copy link
Copy Markdown
Member

@george-sentry george-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is similar to test_watermark_to_commit_step but uses RuntimeOperator::PythonAdapter instead of RuntimeOperator::Map. Since it passes, I approve.

@bmckerry bmckerry merged commit af11ef5 into main May 5, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants