feat: kafka extended configuration for SASL auth & TLS#355
Open
aldy505 wants to merge 2 commits intogetsentry:mainfrom
Open
feat: kafka extended configuration for SASL auth & TLS#355aldy505 wants to merge 2 commits intogetsentry:mainfrom
aldy505 wants to merge 2 commits intogetsentry:mainfrom
Conversation
Collaborator
Author
|
bump @evanpurkhiser |
klochek
reviewed
Oct 10, 2025
| pub struct KafkaConfig { | ||
| /// Kafka security protocol to use. The value must be one of "plaintext, "ssl", "sasl_plaintext", "sasl_ssl". | ||
| /// If not specified, defaults to "plaintext". | ||
| pub kafka_security_protocol: Option<String>, |
Contributor
There was a problem hiding this comment.
If these are the only possible options, let's represent them as an enum, then.
| }, | ||
| results_kafka_cluster: vec!["127.0.0.1:9092".to_owned()], | ||
| results_kafka_topic: "uptime-results".to_owned(), | ||
| kafka_config: KafkaConfig { |
Contributor
There was a problem hiding this comment.
Lets's derive a default for KafkaConfig, so that we can just use that here.
| pub results_kafka_topic: String, | ||
|
|
||
| /// Kafka extended configuration | ||
| #[serde(flatten)] |
Contributor
There was a problem hiding this comment.
Should be able to use #[serde(flatten, with = "kafka_")], and then not have to have the kafka_ prefix on all those struct field names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.