Cargo.toml - enable TLS on redis crate#446
Open
zmarta-erik wants to merge 1 commit intogetsentry:mainfrom
Open
Cargo.toml - enable TLS on redis crate#446zmarta-erik wants to merge 1 commit intogetsentry:mainfrom
zmarta-erik wants to merge 1 commit intogetsentry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
We use a self hosted version of Sentry. In our setup we use Redis with TLS encryption (AWS Elasticache) which works well with other components of Sentry, but not uptime-checker.
Enabling support for TLS on the redis crate fixes this issue. For other methods of self hosting Redis, one might wish to enable 'tls-rustls-insecure' as well (to allow self signed certificates).
I did take a look at previous PRs and issues and I did not spot any previous mention of this, my bad if I overlooked something!