ci(release): Guard publishable package config#79
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c1fe75. Configure here.
Discover publishable packages from manifests so release validation and version bumping cannot silently miss a new package. Validate Craft targets, pack steps, artifact selectors, and action bundle wiring against that package set. Co-Authored-By: OpenAI Codex <codex@openai.com>
Add the new core and report UI packages to Craft and post-merge tarball packing. Harden the release config checker against relative CLI invocation and regex-literal parsing issues reported by PR automation. Co-Authored-By: OpenAI Codex <codex@openai.com>
dcramer
force-pushed
the
codex/release-config-guard
branch
from
1c1fe75 to
715dbec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release validation now treats non-private package manifests as the source of truth for publishable packages. This keeps Craft targets, post-merge packing, version bumping, and bundled action tag wiring from drifting when packages are added.
Seven-package release set
The release config now includes the new
@vitest-evals/coreand@vitest-evals/report-uipackages alongside the existing core package, harness adapters, and GitHub reporter internals. The post-merge pack step dry-runs the same manifest-derived set.Artifact and action safeguards
The release checker validates Craft tarball selectors, scoped package access, the Craft pre-release bump hook, and the bundled
github-reporteraction path used by the release/tag workflows.Review hardening
The regex-literal parser now scans Craft selectors without an inefficient expression, and CLI entrypoint detection normalizes relative paths so
node ./scripts/check-release-config.mjsalways runs the check.Validated locally with
pnpm run release:check,pnpm exec vitest run scripts -c vitest.config.ts, Biome lint,pnpm lint,pnpm docs:check,pnpm typecheck,pnpm run build,pnpm run build:action,pnpm test:ci, and a dry pack of all seven npm tarballs.