Open
Conversation
3a31b26 to
820331b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've inspected the
FeaturesWGPUingfx-rs/wgpuagainst the currentWGPUNativeFeaturesenum, and put them mostly in sync:WGPUNativeFeature_UniformBufferAndStorageTextureArrayNonUniformIndexing->WGPUNativeFeature_StorageTextureArrayNonUniformIndexing(see Updatebinding_arrayrelatedCapabilitieswgpu#4407)WGPUNativeFeature_SpirvShaderPassthrough(I added a newWGPUNativeFeature_PassthroughShaders, but it is commented out, as it requires API changes)wgpuI've updated the conversion code in
conv.rs(in both directions). In cases when actually using a feature would require implementing new API, I've kept the feature enum value and the conversion code commented out for future (this means that for the most part the added extensions are relevant only in shaders).Checklist
cargo clippyreports no issuescargo docreports no issuescargo denyissues have been fixed or added todeny.tomlAdded new functionality. @githubname