CUDA FA: run KV_max mask scan for all Q batch sizes#22137
Open
ssam18 wants to merge 1 commit intoggml-org:masterfrom
Open
CUDA FA: run KV_max mask scan for all Q batch sizes#22137ssam18 wants to merge 1 commit intoggml-org:masterfrom
ssam18 wants to merge 1 commit intoggml-org:masterfrom
Conversation
Contributor
|
This is the wrong fix. Those indices are solely for optimization, any out-of-bounds checks should be working regardless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KV_max mask scan was gated behind Q->ne[1] >= 1024, so decode steps never ran it. This caused the flash attention vec kernel on Pascal GPUs to read past valid KV entries into uninitialized memory beyond the current context, triggering device-side exceptions above 24K tokens. Removing the batch-size guard fixes the crash with negligible overhead since the scan is a single small kernel launch. Fixes #22032