server : add missing return after validation errors in /infill endpoint#22146
Open
JoongHyuk-Shin wants to merge 1 commit intoggml-org:masterfrom
Open
server : add missing return after validation errors in /infill endpoint#22146JoongHyuk-Shin wants to merge 1 commit intoggml-org:masterfrom
JoongHyuk-Shin wants to merge 1 commit intoggml-org:masterfrom
Conversation
The /infill endpoint calls res->error() for missing input_prefix, input_suffix, and non-string prompt, but does not return afterward. Execution falls through to data.at() which throws out_of_range, resulting in HTTP 500 instead of the intended HTTP 400. Add return res; after each of the three validation error calls, matching the pattern already used by the input_extra check below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The /infill endpoint sets error for missing input_prefix,input_suffix but doesn't return,
so it falls through and throws 500 instead of 400.
Added "return res; "
after the three validation checks and a test for each case.
Requirements