sycl: Battlemage AOT build via spir64_gen + MMQ subgroup annotations#22147
Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Open
sycl: Battlemage AOT build via spir64_gen + MMQ subgroup annotations#22147aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Authors
Enables AOT builds for Intel GPUs (validated on Intel® Arc™ Pro B70, BMG-G31, Xe2-HPG):
GGML_SYCL_DEVICE_ARCHis set, switch to-fsycl-targets=spir64_genwith-Xsycl-target-backend="-device <arch>"and skip-ze-intel-greater-than-4GB-buffer-required(not accepted by the AOT path). Behavior is unchanged whenGGML_SYCL_DEVICE_ARCHis unset.[[intel::reqd_sub_group_size(WARP_SIZE)]]to MMQ Q4_0/Q4_1/Q5_0/Q5_1 kernel launches.WARP_SIZE=16on Intel targets; pinning the required subgroup size is required for spir64_gen AOT correctness and documents intent on JIT.Also adds a documentation-only update to
ggml_sycl_supports_mmq(still returns false) and a note inggml_sycl_op_mul_mat_syclrecording that fused dequant+GEMM and MMQ/DPAS were both slower than dequant+oneDNN in our experiments.Additional information
Split from #22066 per reviewer request for independent review.
Requirements