Skip to content

sycl: support non-contiguous input in PAD op#22148

Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai:aicss-genai/sycl-bmg-upstream-pr-2
Open

sycl: support non-contiguous input in PAD op#22148
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai:aicss-genai/sycl-bmg-upstream-pr-2

Conversation

@aicss-genai
Copy link
Copy Markdown

@aicss-genai aicss-genai commented Apr 20, 2026

Overview

Authors

pad_f32 previously assumed contiguous source strides and reconstructed ne00/ne01/ne02 from ne - lp - rp. This broke when the source tensor had non-contiguous strides (common for views).

Pass s00..s03 (source strides in elements) through to the kernel and index with i03*s03 + i02*s02 + i01*s01 + i00*s00. Also switches the grid layout to sycl::range<3> order to match the rest of the backend.

Additional information

Part of work originally submitted as #22066 — splitting per reviewer request.

Requirements

  • I have read and agree with the contributing guidelines
  • AI usage disclosure: Yes. This work was partially produced with an agentic engineering approach: agents surface issues and explore experiments while engineers identify and reject candidates using domain knowledge. Human feedback involved.

@aicss-genai aicss-genai requested a review from a team as a code owner April 20, 2026 06:55
@ggml-gh-bot
Copy link
Copy Markdown

ggml-gh-bot bot commented Apr 20, 2026

Hi @aicss-genai, thanks for your contribution!

Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:

  • Multiple open PRs from a new contributor: We limit new contributors (those without a previously merged PR) to 1 open PR at a time. You currently have 3 open PRs.

  • AI-generated content: This project does not accept PRs, descriptions or commit messages that are fully or predominantly AI-generated. If you have used AI to assist you in writing code, please make sure to disclose that explicitly.


Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ggml changes relating to the ggml tensor library for machine learning SYCL https://en.wikipedia.org/wiki/SYCL - GPU programming language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants