sycl: add FILL, CUMSUM, DIAG, SOLVE_TRI, SSM_SCAN, GATED_DELTA_NET#22149
Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Open
sycl: add FILL, CUMSUM, DIAG, SOLVE_TRI, SSM_SCAN, GATED_DELTA_NET#22149aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Authors
Adds SYCL implementations for six ops previously missing from the backend:
GGML_OP_FILLGGML_OP_CUMSUMGGML_OP_DIAGGGML_OP_SOLVE_TRI(constrained to N ≤SYCL_SOLVE_TRI_MAX_N,K ≤
SYCL_SOLVE_TRI_MAX_K)GGML_OP_SSM_SCAN(two shape regimes: head_dim 128/256 withne1 % WARP_SIZE == 0, and the mamba-1 head_dim=16 case)GATED_DELTA_NET(wired via new header)Each op lives in its own
.cpp/.hpppair underggml/src/ggml-sycl/.Dispatch added to
ggml_sycl_compute_forwardand the shape/type gating added toggml_backend_sycl_device_supports_op.Additional information
Part of work originally submitted as #22066 — splitting per reviewer request.
Note:
GGML_OP_GATED_DELTA_NETmay overlap with parallel upstream work (#20455). Happy to rebase or drop this op from the PR if a canonical implementation is preferred.Requirements