sycl: route small f32 matmuls to oneMKL, bypass oneDNN#22150
Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Open
sycl: route small f32 matmuls to oneMKL, bypass oneDNN#22150aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Authors
For f32 × f32 GEMMs where
M*N*K < 256^3, go directly tooneapi::mkl::blas::column_major::gemminstead of the oneDNN wrapper. oneDNN primitive creation overhead dominates for small GEMMs on Intel Arc; bypassing it measurably improves token generation on small batch sizes.Behavior unchanged when
GGML_SYCL_DISABLE_DNN=1(MKL path was already used) or when the GEMM is large (oneDNN still used). Threshold is a single constant and can be tuned or made configurable if needed.Additional information
Part of work originally submitted as #22066 — splitting per reviewer request.
Requirements