Skip to content

cmake : skip project() when consumed as a subdirectory (#20415) #22151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jinweihan-ai wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −2
Draft

cmake : skip project() when consumed as a subdirectory (#20415) #22151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
cmake_minimum_required(VERSION 3.14...3.28) # for add_link_options and implicit target directories.
project("llama.cpp" C CXX)

# Only call project() when llama.cpp is the top-level build. When consumed as
# a subdirectory, a second project() would re-run toolchain detection and can
# override parent-project settings. See:
# https://github.com/ggml-org/llama.cpp/issues/20415
if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
project("llama.cpp" C CXX)
endif()

include(CheckIncludeFileCXX)

#set(CMAKE_WARN_DEPRECATED YES)
Expand Down
11 changes: 10 additions & 1 deletion ggml/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,16 @@ cmake_minimum_required(VERSION 3.14...3.28) # for add_link_options and implicit
if (POLICY CMP0194)
cmake_policy(SET CMP0194 NEW)
endif()
project("ggml" C CXX ASM)

# Only call project() when ggml is the top-level build. When consumed as a
# subdirectory (FetchContent, CPM, etc.), a second project() would re-run
# toolchain detection and can clobber parent-project settings such as
# CMAKE_OSX_ARCHITECTURES, CMAKE_OSX_SYSROOT or CMAKE_ASM_COMPILER during
# cross-compilation (iOS, Android NDK, arm64/x86_64 hosts).
# See: https://github.com/ggml-org/llama.cpp/issues/20415
if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)
project("ggml" C CXX ASM)
endif()

### GGML Version
set(GGML_VERSION_MAJOR 0)
Expand Down