sycl: Q5_K reorder MMVQ/dequant + Q8_0 reorder MMVQ path#22152
Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Open
sycl: Q5_K reorder MMVQ/dequant + Q8_0 reorder MMVQ path#22152aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Authors
Extends the reorder-quantized codepath to Q5_K (new) and adds a reorder
MMVQ kernel for Q8_0.
block_q_t<GGML_TYPE_Q5_K>specialization with layout[qs (QK_K/2 per block)] [qh (QK_K/8 per block)] [scales] [dm]and matchingget_block_offset/get_d_offset.reorder_qw_q5_k(weight reorder),reorder_mul_mat_vec_q5_k_q8_1_sycl(MMVQ kernel),dequantize_row_q5_K_sycl_reorderand the reorder variant ofdequantize_block_q5_K.ggml_sycl_supports_reorder_mul_mat_sycl,ggml_sycl_supports_reorder_mmvq, and thereorder_qwdispatch.reorder_mul_mat_vec_q8_0_q8_1_sycland inlinesreorder_vec_dot_q_sycl<Q8_0>::operator()(removes the smallvec_dot_q8_0_q8_1_implhelper).dequantize_q8_0_reorderanddequantize_block_q8_0_reorderhelpers used by the Q8_0 reorder MMVQ path.Uses the existing
g_ggml_sycl_use_async_mem_opflag (default off in master); no dependency on #22066's async-toggle change.Additional information
Split from #22066 per reviewer request for independent review.
Requirements