sycl: scalar SWAR byte-subtract in Q6_K MMVQ dot product#22156
Open
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Open
sycl: scalar SWAR byte-subtract in Q6_K MMVQ dot product#22156aicss-genai wants to merge 2 commits intoggml-org:masterfrom
aicss-genai wants to merge 2 commits intoggml-org:masterfrom
Conversation
Signed-off-by: Chun Tao <chun.tao@intel.com>
|
Hi @aicss-genai, thanks for your contribution! Per our contribution guidelines, the automated PR checker found the following issue(s) that need your attention:
Please note that maintainers reserve the right to make final decisions on PRs. If you believe there is a mistake, please comment below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Authors
Small perf cleanup for Q6_K MMVQ on Intel GPUs.
The Q6_K MMVQ dot product previously called
dpct::vectorized_binary<sycl::char4>(..., dpct::sub_sat())to computea byte-wise saturated subtract in a packed
int. On Intel targets this lowers to a scalarized sequence. Replaces it with a 4-byte SWAR trick (((a | 0x80808080u) - b) ^ 0x80808080u, safe under the known-range inputs) and a straight-line two-lane scalar dot (dp4a × 2) instead of theQR6_K-iterated loop.Applied in all three Q6_K MMVQ sites: the standalone
vec_dot_q6_K_q8_1_impl_mmvq, thereorder_vec_dot_q_sycl<Q6_K>method and operator, and the top-levelvec_dot_q6_K_q8_1.Bitwise equivalent on inputs produced by quantization; no accuracy change. Measurable tg improvement on BMG for Q6_K-heavy models.
Additional information
Split from #22066 per reviewer request for independent review.
Requirements